Re: [Libcdio-devel] problems with libcdio on openbsd (and probably netbsd too)

[Rocky Bernstein]

I'll try to look at this over the weekend.

On Tue, Aug 7, 2018 at 6:03 PM, Edd Barrett <address@hidden> wrote:

> Hi all,
>
> Sorry for the delay. Life gets in the way again.
>
> On Tue, Jun 19, 2018 at 05:46:37PM -0400, Rocky Bernstein wrote:
> > I looked over the patches so far and all looks good. Thanks.
> >
> > cdda-player is weird in that it uses a CD-ROM in a way that isn't
> normally
> > done much nowadays: there is a command to the cd-rom to start playing in
> > some sort of audio mode and through a jack on the drive you listen. So
> > other than commands going from the computer to the drive and status
> coming
> > back in response to a command, the CD-ROM is working independently of the
> > computer.
>
> I picked up the OpenBSD port again. I'm noticing two test failures:
>
> ---8<---
> FAIL: mmc_read
> ==============
>
> Error: cdio_get_arg("scsi-tuple") returns NULL.
> FAIL mmc_read (exit status: 22)
>
> FAIL: mmc_write
> ===============
>
> Got READ_CD; Should get back MMC_RDWR_EXCL, the access mode requested.
> FAIL mmc_write (exit status: 17)
> --->8---
>
> These are both caused by a call to get_arg_netbsd() in netbsd.c, which
> does not
> define the access modes that exist in (e.g.) the linux and freebsd drivers.
> The tests are assuming these are implemented :\
>
> For comparison, look at the linux get_arg() and then the netbsd one:
>
>  * http://git.savannah.gnu.org/cgit/libcdio.git/tree/lib/
> driver/netbsd.c#n370
>  * http://git.savannah.gnu.org/cgit/libcdio.git/tree/lib/
> driver/gnu_linux.c#n373
>
> It's not as simple as copy and pasting the switch statement, as the
> netbsd _img_private_t doesn't have the access modes inside.
>
> It'd be great if someone who knows what they are doing (i.e. not me) could
> comment on this. Is there a reason the netbsd driver doesn't implement
> these?
> If so, then we should amend the test, otherwise should I try to implement
> these access modes?
>
> I reckon this affects NetBSD too.
>
> Many thanks!
>
> --
> Best Regards
> Edd Barrett
>
> http://www.theunixzoo.co.uk
>
>