Re: [Libcdio-devel] [RFC/PATCH] add multi extent ISO9660 file support to libcdio

[Pete Batard]

Hi Thomas,

On 2018.06.06 19:13, Thomas Schmitt wrote:
> > - I'm not entirely sure that the sector size array is entirely necessary
>
> The specs say that extents of the same file must be neighbors and in sequence.
> But they do not outrule that an extent's size is not aligned to block size.
> So there could be invalid bytes between extents.

Thanks for the clarification. I don't think having the sector size array 
hurts us much anyway, so if the specs allow for different sector sizes, 
we might as well handle it.

> Then you will see on a filesystem that can store sparse files (here ext4):

That's a bit of a cheat... ;)

I looked into sparse files for NTFS, but that needs to be explicitly 
enabled with an Windows specific attribute during file creation, and I 
think people who are compiling libcdio on file systems that don't have 
sparse support will not be too happy if they have to create a 4GB file, 
especially if their file system is slow.

One option I see however would be to have a second level of tests, that 
could be invoked separately (e.g. 'make extra-test') and with a big 
warning alerting whoever runs them that they are likely to be disk or 
resource intensive.

Regards,

/Pete