Re: [Libcdio-devel] [PATCH 0/2] fix various compilation warnings

[Rocky Bernstein]

On Mon, Mar 13, 2017 at 9:36 AM, Pete Batard <address@hidden> wrote:

> Hi Rocky,
>
> On 2017.03.13 12:47, Rocky Bernstein wrote:
>
>> Cursory look is fine. Since you have access to the libcdio repository, a
>> suggestion is to create a git branch and apply these changes there. Then
>> we
>> will merge that in.
>>
>
> Done.
>
> You'll find that a new 'pbatard-fixes' branch has been pushed to libcdio.


merge now into master. Thanks.

>
>
> If this is too onerous, I'll work from the patches, but attribution may
>> inadvertently get lost at has happened in the past.
>>
>
> I don't really mind for simple fixes like these, but yeah, it's nice to
> have proper attribution.
>
> I've load track libcdio builds on MinGW?
>>
>
> libcdio still builds fine for MinGW, and, at least in my app, I haven't
> seen anything broken. But I'm only using a subset of libcdio there.
>
> There's one test that fails though (realpath.exe, which produces a
> segfault) when running 'make test'. Maybe if I find time to spare, I'll try
> to take a look, but I can't promise anything


If you do, and have the time that would be greatly appreciated!

If not, at some point I'll look into and thanks for the information.


> .
>
> Regards,
>
> /Pete
>
>