[Libcdio-devel] cdio_is_nrg()

[R. Bernstein]

Diego 'Flameeyes' Pettenò noticed a bug in string handling cdio_is_nrg() -
the routine which is supposed to tell you if a file is a Nero NRG image or
not. Basically that routine now just checks to see if the extension ends
in .NRG (any case). If so it's NRG if not, not.

A better check that probably possible is to call the parse nrg routine
which returns a boolean if it can parse it okay. That in fact is what's
done for the corresponding "cdio_is_cuefile" routine. In the past because
the Nero image format  a guess and reverse engineered I thought not to
rely on it too heavily.  But there haven't been too many complaints about
Nero parsing. By changing the semantics of cdio_is_nrg from: "is an NRG
file" to: "is a NRG file that libcdio can handle", maybe this should be
used instead of the current very lame extension test.

And there's also the question of if this parsing routine is used, should
the require ment of the extension ending in .NRG still be enforced?

As always, thoughts and comments and guidence is solicited.