[Koha-cvs] CVS: koha/C4/Circulation Returns.pm,1.4,1.5

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv23417

Modified Files:
        Returns.pm 
Log Message:
Added magic RCS comment.
Added some FIXME comments explaining why I didn't write a POD.
Removed unused finalizer.


Index: Returns.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Returns.pm,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** Returns.pm  7 Oct 2002 00:54:05 -0000       1.4
--- Returns.pm  13 Oct 2002 06:29:37 -0000      1.5
***************
*** 1,3 ****
! package C4::Circulation::Returns; #assumes C4/Circulation/Returns
  
  #package to deal with Returns
--- 1,5 ----
! package C4::Circulation::Returns;
! 
! # $Id$
  
  #package to deal with Returns
***************
*** 22,25 ****
--- 24,31 ----
  # Suite 330, Boston, MA  02111-1307 USA
  
+ # FIXME - None of the functions (certainly none of the exported
+ # functions) are used anywhere anymore. Presumably this module is
+ # obsolete.
+ 
  use strict;
  require Exporter;
***************
*** 78,81 ****
--- 84,91 ----
  # make all your functions, whether exported or not;
  
+ # FIXME - This is only used in C4::Circmain and C4::Circulation, both
+ # of which appear to be obsolete. Presumably this function is obsolete
+ # as well.
+ # Otherwise, it needs a POD.
  sub Returns {
    my ($env)address@hidden;
***************
*** 116,119 ****
--- 126,131 ----
        if ($itemno ne "" ) {
          my $item = itemnodata($env,$dbh,$itemno);
+         # FIXME - This relies on C4::Circulation::Main to have a
+         # "use C4::Circulation::Issues;" line, which is bogus.
          my $fmtitem = 
C4::Circulation::Issues::formatitem($env,$item,"",$amt_owing);
            unshift @items,$fmtitem;
***************
*** 135,139 ****
    return($reason);
    }
!   
  sub checkissue {
    my ($env,$dbh, $item) = @_;
--- 147,154 ----
    return($reason);
    }
! 
! # FIXME - Only used in &Returns and in telnet/doreturns.pl, both of
! # which appear obsolete. Presumably this function is obsolete as well.
! # Otherwise, it needs a POD.
  sub checkissue {
    my ($env,$dbh, $item) = @_;
***************
*** 194,198 ****
    # end checkissue
    }
!   
  sub returnrecord {
    # mark items as returned
--- 209,217 ----
    # end checkissue
    }
! 
! # FIXME - Only used in &C4::Circulation::Main::previousissue,
! # &checkissue, C4/Circulation.pm, and tkperl/tkcirc, all of which
! # appear to be obsolete. Presumably this function is obsolete as well.
! # Otherwise, it needs a POD.
  sub returnrecord {
    # mark items as returned
***************
*** 277,280 ****
--- 296,302 ----
  }
  
+ # FIXME - Only used in tkperl/tkcirc. Presumably this function is
+ # obsolete.
+ # Otherwise, it needs a POD.
  sub calc_odues {
    # calculate overdue fees
***************
*** 284,287 ****
--- 306,313 ----
  }  
  
+ # This function is only used in &checkissue and &returnrecord, both of
+ # which appear to be obsolete. So presumably this function is obsolete
+ # too.
+ # Otherwise, it needs a POD.
  sub updatelastseen {
    my ($env,$dbh,$itemnumber)= @_;
***************
*** 295,298 ****
--- 321,330 ----
       
  }
+ 
+ 
+ # FIXME - There's also a &C4::Circulation::Circ2::find_reserves, but
+ # that one looks rather different.
+ # FIXME - This is only used in &checkissue, which appears to be
+ # obsolete. So presumably this function is obsolete too.
  sub find_reserves {
    my ($env,$dbh,$itemno) = @_;
***************
*** 351,353 ****
    return ($resfound,$resrec);   
  }
- END { }       # module clean-up code here (global destructor)
--- 383,384 ----