[Koha-cvs] CVS: koha/C4 Stats.pm,1.11,1.12

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv20605

Modified Files:
        Stats.pm 
Log Message:
Added magic RCS comment.
Removed declarations for nonexistent variables.
Added some FIXME comments.
Removed unused finalizer.


Index: Stats.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Stats.pm,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -r1.11 -r1.12
*** Stats.pm    10 Oct 2002 04:46:07 -0000      1.11
--- Stats.pm    13 Oct 2002 06:12:00 -0000      1.12
***************
*** 1,4 ****
! package C4::Stats; #assumes C4/Stats
  
  
  # Copyright 2000-2002 Katipo Communications
--- 1,5 ----
! package C4::Stats;
  
+ # $Id$
  
  # Copyright 2000-2002 Katipo Communications
***************
*** 23,27 ****
  use DBI;
  use C4::Context;
! use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
  
  # set the version for version checking
--- 24,28 ----
  use DBI;
  use C4::Context;
! use vars qw($VERSION @ISA @EXPORT);
  
  # set the version for version checking
***************
*** 89,97 ****
  }
  
- # XXX - POD
  # FIXME - Why does this function exist? Why not just rename &circrep
  # to &statsreport?
  # Then again, it only appears to be used in reports.pl which, in turn,
  # doesn't appear to be used. So presumably this function is obsolete.
  sub statsreport {
    #module to return a list of stats for a given day,time,branch type
--- 90,98 ----
  }
  
  # FIXME - Why does this function exist? Why not just rename &circrep
  # to &statsreport?
  # Then again, it only appears to be used in reports.pl which, in turn,
  # doesn't appear to be used. So presumably this function is obsolete.
+ # If not, it needs a POD.
  sub statsreport {
    #module to return a list of stats for a given day,time,branch type
***************
*** 106,110 ****
  }
  
! # XXX - Doc. Only used internally. Probably useless: see comment for
  # &statsreport.
  sub circrep {
--- 107,111 ----
  }
  
! # Only used internally. Probably useless: see comment for
  # &statsreport.
  sub circrep {
***************
*** 116,119 ****
--- 117,121 ----
      $query=$query." where type='$type' and datetime
      >=datetime('yesterday'::date)";
+                       # FIXME - .= <<EOT;
    }
    my $sth=$dbh->prepare($query);
***************
*** 130,135 ****
  }
  
- # XXX - POD
  # FIXME - This is only used in stats.pl, which in turn is never used.
  sub Count {
    my ($type,$branch,$time,$time2)address@hidden;
--- 132,137 ----
  }
  
  # FIXME - This is only used in stats.pl, which in turn is never used.
+ # Otherwise, this needs a POD.
  sub Count {
    my ($type,$branch,$time,$time2)address@hidden;
***************
*** 145,149 ****
  }
  
! # XXX - POD. Doesn't appear to be used
  sub Overdues{
    my $dbh = C4::Context->dbh;
--- 147,152 ----
  }
  
! # FIXME - This function doesn't appear to be used.
! # If it is, it needs a POD.
  sub Overdues{
    my $dbh = C4::Context->dbh;
***************
*** 156,160 ****
  }
  
! # XXX - POD. Never used
  sub TotalOwing{
    my ($type)address@hidden;
--- 159,164 ----
  }
  
! # FIXME - Never used.
! # Otherwise, it'd need a POD.
  sub TotalOwing{
    my ($type)address@hidden;
***************
*** 162,166 ****
    my $query="Select sum(amountoutstanding) from accountlines";
    if ($type eq 'fine'){
!     $query=$query." where accounttype='F' or accounttype='FN'";
    }
    my $sth=$dbh->prepare($query);
--- 166,170 ----
    my $query="Select sum(amountoutstanding) from accountlines";
    if ($type eq 'fine'){
!     $query=$query." where accounttype='F' or accounttype='FN'";       # FIXME 
- .=
    }
    my $sth=$dbh->prepare($query);
***************
*** 172,176 ****
  }
  
! # XXX - POD. Never used
  sub TotalPaid {
    my ($time)address@hidden;
--- 176,181 ----
  }
  
! # FIXME - Never used.
! # Otherwise, it'd need a POD.
  sub TotalPaid {
    my ($time)address@hidden;
***************
*** 180,184 ****
    and accountlines.borrowernumber = borrowers.borrowernumber";
    if ($time eq 'today'){
!     $query=$query." and date = now()";
    } else {
      $query.=" and date='$time'";
--- 185,189 ----
    and accountlines.borrowernumber = borrowers.borrowernumber";
    if ($time eq 'today'){
!     $query=$query." and date = now()";                                # FIXME 
- .=
    } else {
      $query.=" and date='$time'";
***************
*** 207,211 ****
  }
  
! # XXX - POD. Only used in stats.pl, which in turn is never used.
  sub getcharges{
    my($borrowerno,$timestamp)address@hidden;
--- 212,217 ----
  }
  
! # FIXME - Only used in stats.pl, which in turn is never used.
! # Otherwise, it needs a POD.
  sub getcharges{
    my($borrowerno,$timestamp)address@hidden;
***************
*** 229,234 ****
  }
  
! # XXX - POD. This is only used in stats.pl and stats2.pl, neither of
! # which is used.
  sub Getpaidbranch{
    my($date,$borrno)address@hidden;
--- 235,241 ----
  }
  
! # This is only used in stats.pl and stats2.pl, neither of which is
! # used.
! # Otherwise, this needs a POD.
  sub Getpaidbranch{
    my($date,$borrno)address@hidden;
***************
*** 244,249 ****
  }
  
! # XXX - POD. This is only used in reservereport.pl and
! # reservereport.xls, neither of which is used.
  sub unfilledreserves {
    my $dbh = C4::Context->dbh;
--- 251,257 ----
  }
  
! # FIXME - This is only used in reservereport.pl and reservereport.xls,
! # neither of which is used.
! # Otherwise, it needs a POD.
  sub unfilledreserves {
    my $dbh = C4::Context->dbh;
***************
*** 280,285 ****
    return($i,address@hidden);
  }
- 
- END { }       # module clean-up code here (global destructor)
  
  1;
--- 288,291 ----