[Koha-cvs] CVS: koha/C4/Circulation Borrower.pm,1.3,1.4

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv1838

Modified Files:
        Borrower.pm 
Log Message:
Added FIXME comment. This file is obsolete, right?


Index: Borrower.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Borrower.pm,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -r1.3 -r1.4
*** Borrower.pm 5 Oct 2002 09:53:55 -0000       1.3
--- Borrower.pm 11 Oct 2002 12:37:58 -0000      1.4
***************
*** 22,25 ****
--- 22,27 ----
  # Suite 330, Boston, MA  02111-1307 USA
  
+ # FIXME - This module is never used. Obsolete?
+ 
  use strict;
  require Exporter;
***************
*** 86,90 ****
  sub findborrower  {
    my ($env,$dbh) = @_;
!   C4::InterfaceCDK::helptext('');
    C4::InterfaceCDK::clearscreen();
    my $bornum = "";
--- 88,92 ----
  sub findborrower  {
    my ($env,$dbh) = @_;
!   C4::InterfaceCDK::helptext('');     # FIXME - This looks useless
    C4::InterfaceCDK::clearscreen();
    my $bornum = "";
***************
*** 372,376 ****
    reservesdisplay($env,$borrower,$amount,$odues,address@hidden);
  }
!   
  sub NewBorrowerNumber {
    my $dbh = C4::Context->dbh;
--- 374,399 ----
    reservesdisplay($env,$borrower,$amount,$odues,address@hidden);
  }
! 
! =item NewBorrowerNumber
! 
!   $num = &NewBorrowerNumber();
! 
! Allocates a new, unused borrower number, and returns it.
! 
! =cut
! #'
! # FIXME - This is identical to C4::Search::NewBorrowerNumber.
! # Pick one (preferably this one) and stick with it.  
! 
! # FIXME - Race condition: this function just says what the next unused
! # number is, but doesn't allocate it. Hence, two clients adding
! # patrons at the same time could get the same new borrower number and
! # clobber each other.
! # A better approach might be to change the database to make
! # borrowers.borrowernumber a unique key and auto_increment. Then, to
! # allocate a new borrower number, use "insert" to create a new record
! # (leaving the database daemon with the job of serializing requests),
! # and use the newly-created record.
! 
  sub NewBorrowerNumber {
    my $dbh = C4::Context->dbh;