[Koha-cvs] CVS: koha/C4 Reserves2.pm,1.21,1.22

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv25077

Modified Files:
        Reserves2.pm 
Log Message:
Added some FIXMEs.


Index: Reserves2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Reserves2.pm,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -r1.21 -r1.22
*** Reserves2.pm        5 Oct 2002 09:52:25 -0000       1.21
--- Reserves2.pm        9 Oct 2002 14:13:31 -0000       1.22
***************
*** 119,122 ****
--- 119,123 ----
                                AND biblioitems.itemtype = itemtypes.itemtype
                                AND barcode=$qbc");
+       # FIXME - This function uses $item later on. Ought to set it here.
      }
      $sth->execute;
***************
*** 131,134 ****
--- 132,137 ----
      if ($count) {
        foreach my $res (@reserves) {
+           # FIXME - $item might be undefined or empty: the caller
+           # might be searching by barcode.
            if ($res->{'itemnumber'} == $item) {
                return ("Waiting", $res);
***************
*** 141,145 ****
        }
      }
!     if ($highest) {
        $highest->{'itemnumber'} = $item;
        return ("Reserved", $highest);
--- 144,148 ----
        }
      }
!     if ($highest) {   # FIXME - $highest might be undefined
        $highest->{'itemnumber'} = $item;
        return ("Reserved", $highest);