[Koha-cvs] CVS: koha/C4 Search.pm,1.41,1.42

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv18271

Modified Files:
        Search.pm 
Log Message:
Fixed some bogosity.
Added some FIXMEs.


Index: Search.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Search.pm,v
retrieving revision 1.41
retrieving revision 1.42
diff -C2 -r1.41 -r1.42
*** Search.pm   5 Oct 2002 09:52:52 -0000       1.41
--- Search.pm   5 Oct 2002 23:59:40 -0000       1.42
***************
*** 89,100 ****
    my $sth=$dbh->prepare($query);
    $sth->execute;
    my @dat;
!   my $i=0;
!   while (my $data=$sth->fetchrow_hashref){
!     $dat[$i]=$data;
!     $i++;
    }
    $sth->finish;
!   return($i,address@hidden);
  }
  
--- 89,100 ----
    my $sth=$dbh->prepare($query);
    $sth->execute;
+ 
    my @dat;
!   while (my $data = $sth->fetchrow_hashref)
!   {
!     push @dat, $data;
    }
    $sth->finish;
!   return (scalar(@dat), address@hidden);
  }
  
***************
*** 142,145 ****
--- 142,148 ----
  =cut
  #'
+ # FIXME - This function is no longer used; in cases where you just
+ # care about one preference (which is true for most scripts), use
+ # C4::Context->preference.
  sub systemprefs {
      my %systemprefs;
***************
*** 162,165 ****
--- 165,171 ----
  =cut
  #'
+ # FIXME - This is identical to C4::Circulation::Borrower::NewBorrowerNumber.
+ # Pick one and stick with it. Preferably use the other one. This function
+ # doesn't belong in C4::Search.
  sub NewBorrowerNumber {
    my $dbh = C4::Context->dbh;