[Koha-cvs] CVS: koha/C4/Circulation Circ2.pm,1.37.2.1,1.37.2.2

[Andrew Arensburger]

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv32503

Modified Files:
      Tag: arensb-context
        Circ2.pm 
Log Message:
Added a whole mess of FIXME comments.


Index: Circ2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v
retrieving revision 1.37.2.1
retrieving revision 1.37.2.2
diff -C2 -r1.37.2.1 -r1.37.2.2
*** Circ2.pm    4 Oct 2002 02:27:30 -0000       1.37.2.1
--- Circ2.pm    5 Oct 2002 06:14:52 -0000       1.37.2.2
***************
*** 516,520 ****
  # update issues, thereby returning book (should push this out into another 
subroutine
      my ($borrower) = getpatroninformation(\%env, $currentborrower, 0);
!     if ($doreturn) {
        doreturn($borrower->{'borrowernumber'}, 
$iteminformation->{'itemnumber'});
        $messages->{'WasReturned'};
--- 516,520 ----
  # update issues, thereby returning book (should push this out into another 
subroutine
      my ($borrower) = getpatroninformation(\%env, $currentborrower, 0);
!     if ($doreturn) {  # FIXME - perl -wc complains about this line.
        doreturn($borrower->{'borrowernumber'}, 
$iteminformation->{'itemnumber'});
        $messages->{'WasReturned'};
***************
*** 523,531 ****
  # transfer book
      my ($transfered, $mess, $item) = transferbook($branch, $barcode, 1);
!     if ($transfered) {
        $messages->{'WasTransfered'};
      }
  # fix up the accounts.....
!     if ($iteminformation->{'itemlost'}) {
        updateitemlost($iteminformation->{'itemnumber'});
        fixaccountforlostandreturned($iteminformation, $borrower);
--- 523,531 ----
  # transfer book
      my ($transfered, $mess, $item) = transferbook($branch, $barcode, 1);
!     if ($transfered) {        # FIXME - perl -wc complains about this line.
        $messages->{'WasTransfered'};
      }
  # fix up the accounts.....
!     if ($iteminformation->{'itemlost'}) {     # FIXME - perl -wc complains 
about this line.
        updateitemlost($iteminformation->{'itemnumber'});
        fixaccountforlostandreturned($iteminformation, $borrower);
***************
*** 1041,1044 ****
--- 1041,1048 ----
  }
  
+ # FIXME - This is almost, but not quite, identical to
+ # &C4::Circulation::Issues::calc_charges and
+ # &C4::Circulation::Renewals2::calc_charges.
+ # Pick one and stick with it.
  sub calc_charges {
  # Stolen from Issues.pm