Re: [Koha-cvs] CVS: koha/C4 Biblio.pm,1.11,1.12

[paul POULAIN]

Andrew Arensburger wrote:

> Update of /cvsroot/koha/koha/C4
> In directory usw-pr-cvs1:/tmp/cvs-serv644
>
> Modified Files:
> 	Biblio.pm 
> Log Message:
> Added some FIXME comments, mostly marking duplicate functions.
Andrew,

* Acquisition.pm is deprecated in 1.3.x series and will be deleted soon 
from CVS.
* Subs that are wrappers to OLDxxx are unstable ones : they will be 
completed during the march to 1.4.0 to manage MARC-DB too. Read the 
beginning of Biblio.pm to have some explanations about how it works.

Thx for the other comments
--
Paul

> Index: Biblio.pm
> ===================================================================
> RCS file: /cvsroot/koha/koha/C4/Biblio.pm,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -C2 -r1.11 -r1.12
> *** Biblio.pm   24 Sep 2002 13:49:26 -0000      1.11
> --- Biblio.pm   1 Oct 2002 11:48:51 -0000       1.12
> ***************
> *** 2,5 ****
> --- 2,8 ----
>  # $Id$
>  # $Log$
> + # Revision 1.12  2002/10/01 11:48:51  arensb
> + # Added some FIXME comments, mostly marking duplicate functions.
> + #
>  # Revision 1.11  2002/09/24 13:49:26  tipaul
>  # long WAS the road to 1.3.0...
> ***************
> *** 1427,1430 ****
> --- 1430,1435 ----
>  }
>  
> + # FIXME - A nearly-identical function, &delitem, appears in
> + # C4::Acquisitions
>  sub OLDdelitem{
>    my ($dbh,$itemnum)address@hidden;
> ***************
> *** 1528,1531 ****
> --- 1533,1538 ----
>  #
>  
> + # FIXME - This is the same as &C4::Acquisitions::itemcount, but not
> + # the same as &C4::Search::itemcount
>  sub itemcount{
>    my ($biblio)address@hidden;
> ***************
> *** 1557,1560 ****
> --- 1564,1569 ----
>  }
>  
> + # FIXME - This is practically the same function as
> + # &C4::Acquisitions::getsingleorder and &C4::Catalogue::getsingleorder
>  sub getsingleorder {
>    my ($ordnum)address@hidden;
> ***************
> *** 1598,1601 ****
> --- 1607,1612 ----
>  
>  
> + # FIXME - This is functionally identical to
> + # &C4::Acquisitions::modaddauthor
>  sub modaddauthor {
>      my ($bibnum, $author) = @_;
> ***************
> *** 1629,1632 ****
> --- 1640,1645 ----
>  }
>  
> + # FIXME - This is quite similar in effect to &C4::newbiblioitem,
> + # except for the MARC stuff.
>  sub newbiblioitem {
>    my ($biblioitem) = @_;
> ***************
> *** 1647,1650 ****
> --- 1660,1665 ----
>  }
>  
> + # FIXME - This is just a wrapper around &OLDnewsubtitle
> + # FIXME - This is in effect the same as &C4::Acquisitions::newsubtitle
>  sub newsubtitle {
>      my ($bibnum, $subtitle) = @_;
> ***************
> *** 1718,1721 ****
> --- 1733,1738 ----
>  }
>  
> + # FIXME - This is just a wrapper around &OLDdelitem, and acts
> + # identically to &C4::Acquisitions::delitem
>  sub delitem{
>    my ($itemnum)address@hidden;
>