|
From: | Jamison Hope |
Subject: | Re: [Kawa-commonlisp-dev] [PATCH] DECLARE processing. |
Date: | Tue, 14 Aug 2012 16:48:26 -0400 |
On Aug 14, 2012, at 4:26 PM, Charles Turner wrote:
On 14 August 2012 21:22, Jamison Hope <address@hidden> wrote:I wasn't sure what he meant, either, but I think you got it right. I don't see the FIXME you mentioned, though (at least not in so many words). Is it this comment? + // if declIterator.next() is not an instance of Pair, fail.Sorry Jamison, don't know what's wrong with me tonight. That's what I was referring to.
No worries! :-) I don't know the answer to your question (best way to signal a syntax error in a void method). Put a literal "FIXME" or "TODO" in that comment so that we can hypothetically remember to revisit it later; other than that, the patch looks fine to me. -Jamie -- Jamison Hope The PTR Group www.theptrgroup.com
[Prev in Thread] | Current Thread | [Next in Thread] |