[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
locking entire tree for write
From: |
Derek Robert Price |
Subject: |
locking entire tree for write |
Date: |
Thu, 09 Oct 2003 16:23:11 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Correct me if I am wrong, but there is no good reason for the
lock_tree_for_write calls in admin.c, edit.c, and watch.c. The three
files contain four calls and all are of the form:
~ lock_tree_for_write
~ start_recursion(...CVS_LOCK_NONE...)
~ Lock_Cleanup
with no intervening calls. I believe that in all four locations this
could be replaced with the single call to:
~ start_recursion(...CVS_LOCK_WRITE...)
as cvs tag and rtag do and that this would be more efficient, allowing
only a directory at a time to be locked rather than locking an entire
tree for the duration of the entire operations.
Just wanted to run this by the list before I changed those calls on stable.
Derek
- --
~ *8^)
Email: address@hidden
Get CVS support at <http://ximbiot.com>!
- --
My name is not Dr. Death.
My name is not Dr. Death.
My name is not Dr. Death...
~ - Bart Simpson on chalkboard, _The Simpsons_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org
iD8DBQE/hcOuLD1OTBfyMaQRAqnZAKCHoSLFL4lB/ejg18UJKyGEsKZv/QCgvjWd
7bWsJiSUdqZgWLES1cRbdNk=
=vA3R
-----END PGP SIGNATURE-----
- locking entire tree for write,
Derek Robert Price <=