Re: RSE's cvs import patch against the current CVS source

[Mark D. Baushke]

Julien Wajsberg <address@hidden> writes:

> I just saw that 'verifymsg' is processed before 'importinfo' with your
> patch. I don't think it is the correct behaviour :)

I suggest that you should not depend on the ordering of the verifymsg as
compared to the importinfo or commitinfo.

In client/server mode, verifymsg is processed first. In local mode,
verifymsg is usually called after the commitinfo has been called.

It is just as reasonable to reject a commit due to a bad log message as
it is to reject it because a file is being committed does not pass some
commitinfo check.
 
> How about modifying this ?

I believe it would be a waste of time. There is still an 'enhancement'
request http://ccvs.cvshome.org/issues/show_bug.cgi?id=27 to have the
verifymsg processed only once rather than for each directory...

> Somewhere before the call to do_verify ?

I'd suggest that this is not a useful distraction for RSE right now.

        Thanks,
        -- Mark