RE: Wins1.2 tag problems - Why not allow period?

[Chris Cameron]

I investigated this same issue a year or two ago.  I can't remember all the
details, but it is to do with the way that tags and revisions are detected.
The . is a revision separator and there were potential "gotcha's" with using
a . in a tag as well.  It took me a while to get straight in my head why
this was a BAD IDEA, but eventually came to the conclusion that it was.
There may well have been a discussion here about this issue if you search
the archives.

***************************************************************
Chris Cameron                       Open Telecommunications Ltd
Product Manager                           IN Product Management
address@hidden                           P.O.Box 10-388
      +64 4 495 8403 (DDI)                          The Terrace
fax:  +64 4 495 8419                                 Wellington
cell: +64 21 650 680                                New Zealand
Life, don't talk to me about life ....(Marvin - HHGTTG)

> -----Original Message-----
> From: address@hidden [mailto:address@hidden Behalf Of
> A.Sulaiman
> Sent: Wednesday, 8 August 2001 2:45 p.m.
> To: address@hidden
> Cc: address@hidden
> Subject: RE: Wins1.2 tag problems - Why not allow period?
>
>
> Not being able to have a period in my tag is to me a major pain,
> and changing it (at first glance) seems very painless.
>
> Grepping the error message, I quickly track down it's origin
> in rcs.c, "void RCS_check_tag (tag)" - line 3591 in cvs-1.10.8
>
> It seems very simple to modify
>     char *invalid = "$,.:;@";
> to
>    char *invalid = "$,:;@";
>
> As for distinguishing tagname from revision name, this is what
> the next routine, "int RCS_valid_rev (rev)" had in it's comment:
>   /*
>    * TRUE if argument has valid syntax for an RCS revision or
>    * branch number.  All characters must be digits or dots, first
>    * and last characters must be digits, and no two consecutive
>    * characters may be dots.
>    *
>    */
>
> Can anyone let me know why I must not apply this fix.
>
> Thank You
> --Asri
> --------------------------------------------------------------------
> > > On Wed, 1 Aug 2001, Thornley, David wrote:
> > > From: address@hidden [mailto:address@hidden
> > > Subject: Wins1.2 tag problems
>
> > > I've tried to tag a entire module using WinCvs 1.2
> > > without success I got the following message:
> > >  cvs rtag -a -r 1.2 Version1.3 gui
> > >   cvs [rtag aborted]: tag `Version1.3' must not contain
> > >  the characters `$,.:;@'
> > >
>
> > You put a period in the tagname, and you can't do that.  In fact,
> > you can't use any of the listed characters in a tagname.  Use
> > something like "Version1_3" instead.  It's a minor pain, but there
> > has to be some way of distinguishing a tagname from a revision
> > number.
> >
>
>
>
> _______________________________________________
> Info-cvs mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/info-cvs
>