RE: Wins1.2 tag problems - Why not allow period?

[A.Sulaiman]

Not being able to have a period in my tag is to me a major pain,
and changing it (at first glance) seems very painless.

Grepping the error message, I quickly track down it's origin
in rcs.c, "void RCS_check_tag (tag)" - line 3591 in cvs-1.10.8

It seems very simple to modify
    char *invalid = "$,.:;@";
to
   char *invalid = "$,:;@";

As for distinguishing tagname from revision name, this is what
the next routine, "int RCS_valid_rev (rev)" had in it's comment:
  /*
   * TRUE if argument has valid syntax for an RCS revision or
   * branch number.  All characters must be digits or dots, first
   * and last characters must be digits, and no two consecutive
   * characters may be dots.
   *
   */

Can anyone let me know why I must not apply this fix.

Thank You
--Asri
--------------------------------------------------------------------
> > On Wed, 1 Aug 2001, Thornley, David wrote:
> > From: address@hidden [mailto:address@hidden
> > Subject: Wins1.2 tag problems

> > I've tried to tag a entire module using WinCvs 1.2
> > without success I got the following message:
> >  cvs rtag -a -r 1.2 Version1.3 gui
> >   cvs [rtag aborted]: tag `Version1.3' must not contain
> >  the characters `$,.:;@'
> >

> You put a period in the tagname, and you can't do that.  In fact,
> you can't use any of the listed characters in a tagname.  Use
> something like "Version1_3" instead.  It's a minor pain, but there
> has to be some way of distinguishing a tagname from a revision
> number.
>