[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH 1/2] kernel: Make >>#new/>>#new: go through
From: |
Holger Hans Peter Freyther |
Subject: |
Re: [Help-smalltalk] [PATCH 1/2] kernel: Make >>#new/>>#new: go through >>#initialize |
Date: |
Thu, 24 Jul 2014 20:24:18 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 24, 2014 at 08:16:49PM +0200, Holger Hans Peter Freyther wrote:
Dear Paolo,
> In Pharo it is common that new/new: will already go through an
> initialize call. When porting code from and to Pharo one needs
> to make sure that initialize is called and only called once or
> idempotent. Align the code with Pharo.
this is a common porting issue from GST to Pharo (initialize being
called twice) or Pharo to GST (initialize is never called). In my
opinion the amount of code tested/written for Pharo will increase
so we should make porting more easy. E.g. the "TimerScheduler" I
ported to Pharo ended up spawning the polling process twice due
>>#initialize being called twice.
On top of that we have a lot of code using the "self *new initialize"
pattern. The benchmark system is not set-up yet so I can't tell you
if there is a big change here (but we could always fix that by
calling basicNew).
What do you think? Is there anything missing besides the ChangeLog?
holger