[Help-smalltalk] [BUG] Behavior>>allSharedPools is broken

[Lee Duhem]

Hi all,

It looks like Behavior>>allSharedPools is broken:

    st> Array allSharedPools
    Object: Dictionary new: 1024 "<-0x4cf02048>" error: did not
understand #nameIn:
    MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
    Dictionary(Object)>>doesNotUnderstand: #nameIn: (SysExcept.st:1408)
    [] in Array class(Behavior)>>allSharedPools (Behavior.st:808)
    OrderedCollection>>do: (OrderColl.st:67)
    Class class>>allPoolDictionaries:except:do: (Class.st:70)
    Object class(Class)>>allLocalSharedPoolDictionariesExcept:do: (Class.st:703)
    [] in Array
class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:679)
    Array class(Behavior)>>withAllSuperclassesDo: (Behavior.st:1146)
    Array class(Class)>>allSharedPoolDictionariesDo:overrideEnvironment:
(Class.st:662)
    Array class(Class)>>allSharedPoolDictionariesDo: (Class.st:652)
    Array class(Behavior)>>allSharedPools (Behavior.st:809)
    UndefinedObject>>executeStatements (a String:1)
    nil
    st> Array allSharedPoolDictionariesDo: [:e | e class printNl ]
    BindingDictionary
    BindingDictionary
    BindingDictionary
    BindingDictionary
    BindingDictionary
    BindingDictionary
    Dictionary
    SystemDictionary
    Array
    st>

This Dictionary which cannot understand #nameIn: is VMPrimitives. Should it
also be a BindingDictionary?

Anyway, the attached patch makes VMPrimitives a BindingDictionary, fixes the
Behavior>>allSharedPools, and does not introduce any regression error.

BTW, I would like to provide a test case for Behavior>>allSharedPools, but
I am not sure what to expect.

lee

ChangeLog

2013-12-16  Lee Duhem <address@hidden>

    * libgst/dict.c: Make VMPrimitives a BindingDictionary.

Make-VMPrimitives-BindingDictionary.patch
Description: Text Data