|
From: | Paolo Bonzini |
Subject: | Re: [Help-smalltalk] OrderedCollection growing |
Date: | Mon, 04 Jul 2011 13:14:27 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 07/04/2011 12:05 PM, Gwenael Casaccio wrote:
So here is the patch.
This is not a patch, it is 10 patches including multiple reverts of pieces that you have already submitted.
You should have grouped the patches in two, one for #beConsistent and one squashing everything else.
I've changed OrederedCollection to use #replaceFrom:to:with:startingAt, SortedCollection uses the Smalltalk implementation but for growing I call the primitive. And OrderedSet uses the St implementation.
Why? Is it just because the ordered_set_class is not available? I believe this rather shows that class checks are too specific.
I pulled some changes in stable-3.2 and others in master only. Please test master and see how performance compares with your code.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |