[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pkg general-1.0.0.tar.gz installs only m-files
From: |
David Bateman |
Subject: |
Re: pkg general-1.0.0.tar.gz installs only m-files |
Date: |
Tue, 10 Apr 2007 16:28:09 +0200 |
User-agent: |
Thunderbird 1.5.0.7 (X11/20060921) |
address@hidden wrote:
> Hello,
>
> although this list is not dedicated to octave-forge, I want to
> remark that the package general-1.0.0.tar.gz is only partly installed
> using the new packaging system. The files in src are not compiled
> during the installation process
> and it seems there's something wrong with the Makefile, which I
> changed in a simple way.
>
> Hartmut
> ------------------------------------------------------------------------
>
> *** Makefile Sun Aug 20 14:25:20 2006
> --- Makefile.hwz Tue Apr 10 15:39:10 2007
> ***************
> *** 1,10 ****
> sinclude ../../Makeconf
>
> ! PROGS=command.oct deref.oct mark_for_deletion.oct
>
> all: $(PROGS)
>
> ! $(PROGS): Makefile
>
> clean:
> -$(RM) *.o core octave-core *.oct
> --- 1,18 ----
> sinclude ../../Makeconf
>
> ! PROGS=SHA1.oct deref.oct mark_for_deletion.oct
> ! MKOCTFILE=mkoctfile
>
> all: $(PROGS)
>
> ! SHA1.oct: SHA1.cc
> ! $(MKOCTFILE) $< -o $@
> !
> ! deref.oct: deref.cc
> ! $(MKOCTFILE) $< -o $@
> !
> ! mark_for_deletion.oct: mark_for_deletion.cc
> ! $(MKOCTFILE) $< -o $@
>
> clean:
> -$(RM) *.o core octave-core *.oct
>
>
Ok, that is not a bad approach though I'd say a Makefile like
PROGS = $(patsubst %.cc,%.oct,$(wildcard *.cc))
all: $(PROGS)
$(PROGS): Makefile
%.oct: %.cc
mkoctfile $<
clean: ; rm *.o core octave-core *.oct *~
might be better as it is generic. Note that no makefile in the packages
should include a line like "sinclude ../../Makeconf". This is a holdover
from the old monolithic octave-forge and should have been removed.. The
package extra/xraylib seems to be the only other one with this issue.
D.
--
David Bateman address@hidden
Motorola Labs - Paris +33 1 69 35 48 04 (Ph)
Parc Les Algorithmes, Commune de St Aubin +33 6 72 01 06 33 (Mob)
91193 Gif-Sur-Yvette FRANCE +33 1 69 35 77 01 (Fax)
The information contained in this communication has been classified as:
[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary
- [no subject], mustafa yurtkolesi, 2007/04/09
- Re:, Geordie McBain, 2007/04/10
- Re:, David Bateman, 2007/04/10