Re: providing a libidn compatibility API

[Tim Rühsen]

On Sonntag, 19. Februar 2017 10:11:42 CET Simon Josefsson wrote:
> Nikos Mavrogiannopoulos <address@hidden> writes:
> > Hi,
> > 
> >  What do you think of the following merge request:
> >  https://gitlab.com/jas/libidn2/merge_requests/4
> > 
> > It introduces a (very-limited) compatibility API with libidn, allowing
> > several applications to switch from IDNA2003 to IDNA2008 by changing
> > idna.h with idn2.h.
> 
> I like the idea of a compatibility layer -- but I strongly believe we
> need to keep the ^idn2_.* namespace in the shared library, everything
> else will cause serious confusion in distributions when apps will be
> linked to both libraries.  Mapping idn_* into idn2_* calls should be
> done through a header file, so which symbol is needed is decided at
> compilation time.

The mapping is done in idn2.h(.in), protected by
#if !defined IDNA_H && !defined IDN2_SKIP_LIBIDN_COMPAT

So, if idna.h is included before idn2.h the mapping is skipped.
Also when IDN2_SKIP_LIBIDN_COMPAT is set before including idn2.h - just in 
case someone wants that.

Regards, Tim

signature.asc
Description: This is a digitally signed message part.