Iterating over all buffer lines

[Sean McAfee]

I have some code where I want to loop over all of the lines of text in a
buffer.  I had a prior solution that involved repeatedly searching for
the regexp "^.+$", but that seemed a little heavyweight.  Also, it only
found non-empty lines, and changing the "+" to a "*" to return all lines
causes an infinite loop.

I just tried my hand at writing a general iterate-all-lines construct,
and came up with this:

(loop for last-point = (point)
      while (= 0 (forward-line))
      for line = (buffer-substring-no-properties
                  last-point
                  (- (point) (if (bolp) 1 0)))
      ;; do something with line
)

Newlines are not returned, and as can be seen, I have to take care to
handle a final line that is missing a terminating newline.

Is there a better and/or more idiomatic way to go about it?