Re: smtp issues: progress indicator and gracious failure

[Stefan Monnier]

> thanks, fantastic!  what version of emacs can I apply this patch to?
> I tried trunk and it failed, although I may have done this
> incorrectly.  cheers, E

It's meant to be applied to `trunk' and seems to apply fine for me.
Here it is again, freshly regenerated from trunk, and bundled up in
a MIME attachment.


        Stefan


=== modified file 'lisp/mail/smtpmail.el'
--- lisp/mail/smtpmail.el       2011-02-12 17:51:02 +0000
+++ lisp/mail/smtpmail.el       2011-05-22 18:39:23 +0000
@@ -941,15 +941,20 @@
   (process-send-string process "\r\n"))
 
 (defun smtpmail-send-data (process buffer)
-  (let ((data-continue t) sending-data)
+  (let ((data-continue t) sending-data
+        (pr (make-progress-reporter "Sending email"
+                                    (with-current-buffer buffer (point-min))
+                                    (with-current-buffer buffer (point-max)))))
     (with-current-buffer buffer
       (goto-char (point-min)))
     (while data-continue
       (with-current-buffer buffer
+        (progress-reporter-update pr (point))
         (setq sending-data (buffer-substring (point-at-bol) (point-at-eol)))
        (end-of-line 2)
         (setq data-continue (not (eobp))))
-      (smtpmail-send-data-1 process sending-data))))
+      (smtpmail-send-data-1 process sending-data))
+    (progress-reporter-done pr)))
 
 (defun smtpmail-deduce-address-list (smtpmail-text-buffer header-start 
header-end)
   "Get address list suitable for smtp RCPT TO: <address>."