[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gzz] Re: [Gzz-commits] fenfire/org/fenfire bin/fenpdf10.py demo/buoyoi.
From: |
Tuomas Lukka |
Subject: |
[Gzz] Re: [Gzz-commits] fenfire/org/fenfire bin/fenpdf10.py demo/buoyoi... |
Date: |
Sun, 10 Aug 2003 12:04:14 +0300 |
User-agent: |
Mutt/1.5.4i |
On Sun, Aug 10, 2003 at 11:47:18AM +0300, Matti Katila wrote:
> On Sun, 10 Aug 2003, Tuomas Lukka wrote:
> > On Sat, Aug 09, 2003 at 01:29:24PM -0400, Matti Katila wrote:
> > > Log message:
> > > just coding..
> >
> > Please explain in at least a rough sense *WHAT* you've changed and why.
>
> 'Just coding' is a good shorthand for cleaning and fixing things ;)
But looking at the patch there were new features there.
> [Don't take this too seriously. Saturday patches can sometimes be named
> with a less rough sense.]
Yes, I understand this is tongue-in-cheek.
Still, the point is that when submitting the patch, you should think
that you're not *coding*, you're *communicating* about what you've
just coded to us others, both through the commitbot and gzz-commits.
It pays to make the commit in several pieces if you can split it
logically, with good comments.
Tuomas