[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34435] [PATCH 3/3] gnu: Add kscreenlocker.
|
From: |
Hartmut Goebel |
|
Subject: |
[bug#34435] [PATCH 3/3] gnu: Add kscreenlocker. |
|
Date: |
Tue, 12 Feb 2019 09:45:41 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Am 11.02.19 um 16:18 schrieb Marius Bakke:
> + (native-inputs
> + `(("extra-cmake-modules" ,extra-cmake-modules)
> + ("pkg-config" ,pkg-config)
> +
Empty line.
> + ("logind" ,elogind) ;optional loginctl support
According to my notes (for 5.13.5) this is a run-time dependency. Why do
we need to list it here and not later in some "service"?
Another thing: I suggest keeping al l Plasma related packages in a
module of it's own. This will help keeping modules small, easy to spot
and easier to maintain.
Otherwise LGTM
--
Regards
Hartmut Goebel
| Hartmut Goebel | address@hidden |
| www.crazy-compilers.com | compilers which you thought are impossible |