[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31999] [bug#32299] [PATCH 1/7] gnu: Add volume-key.
From: |
Pierre Neidhardt |
Subject: |
[bug#31999] [bug#32299] [PATCH 1/7] gnu: Add volume-key. |
Date: |
Mon, 30 Jul 2018 11:19:11 +0200 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Marius Bakke <address@hidden> writes:
> Pierre Neidhardt <address@hidden> writes:
>
>> * gnu/package/disk.scm (volume-key): New variable.
>
> [...]
>
>> +(define-public volume-key
>> + (package
>> + (name "volume-key")
>> + (version "0.3.10")
>
> 0.3.11 is out!
>
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append
>> "https://releases.pagure.org/volume_key/volume_key-"
>> + version ".tar.xz"))
>> + (sha256
>> + (base32
>> + "19wqgrd0cnnjs1b1d7s9ssc957vis8vj7bls9rkwhf9ywgkrswn5"))))
>> + (build-system gnu-build-system)
>> + (native-inputs
>> + `(("pkg-config" ,pkg-config)
>> + ("util-linux" ,util-linux)
>> + ("glib" ,glib)
>> + ("swig" ,swig)
>> + ("lvm2" ,lvm2)
>> + ("python" ,python-2))) ; Used to generate the Python
>> bindings.
>
> Are you sure lvm2 and glib are native-inputs? I.e. are they truly only
> needed for building, and not at runtime?
>
> Other than that LGTM!
>
>> + (inputs
>> + `(("cryptsetup" ,cryptsetup)
>> + ("nss" ,nss)
>> + ("gpgme" ,gpgme)))
>> + (arguments
>> + `(#:tests? #f ; Not sure how tests are supposed to pass, even when run
>> manually.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-before 'configure 'patch-python.h-path
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (let ((python (assoc-ref inputs "python")))
>> + (substitute* "Makefile.in"
>> + (("/usr/include/python") (string-append python
>> "/include/python")))
>> + #t))))))
>> + (home-page "https://pagure.io/volume_key")
>> + (synopsis "Manipulate storage volume encryption keys")
>> + (description
>> + "This package provides a library for manipulating storage volume
>> +encryption keys and storing them separately from volumes to handle forgotten
>> +passphrases.")
>> + (license license:gpl2)))
>> --
>> 2.18.0
Acknowledged.
But mind the confusion with the bug number (my bad, I messed up).
I'm CC'ing this answer to the right bug number.
--
Pierre Neidhardt
signature.asc
Description: PGP signature
[bug#31999] [PATCH 1/7] gnu: Add volume-key., Pierre Neidhardt, 2018/07/28