guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31965] [PATCH] gnu: Add gaupol.


From: Ludovic Courtès
Subject: [bug#31965] [PATCH] gnu: Add gaupol.
Date: Thu, 12 Jul 2018 23:20:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello Pierre!

Pierre Neidhardt <address@hidden> skribis:

> * gnu/packages/video.scm (gaupol): New variable.

[...]

> +         (add-after 'install 'patch-data-dir
> +           ;; Fix some path variables that setup.py seems to garble.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* (string-append out 
> "/lib/python3.6/site-packages/aeidon/paths.py")

This could break silently the day we switch to Python 3.7.  Instead, I
think you can write:

  (substitute* (find-files out "^paths\\.py$")
    …)

There’s possibly another issue: if there exists a ‘paths.pyc’ file, it
becomes outdated once we’ve modified ‘paths.py’.

Perhaps we should move this phase before the build phase?

Otherwise LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]