[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29483] [PATCH] services: Add openntpd service.
From: |
Ludovic Courtès |
Subject: |
[bug#29483] [PATCH] services: Add openntpd service. |
Date: |
Sun, 04 Mar 2018 23:21:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Efraim Flashner <address@hidden> skribis:
> On Fri, Mar 02, 2018 at 05:46:30PM +0100, Ludovic Courtès wrote:
[...]
>> To be clear, the switch from ‘match-lambda’ to ‘match-record’ should be
>> entirely mechanical. The above snippet would become:
>>
>> (define (openntpd-shepherd-service config)
>> (match-record config <openntpd-configuration>
>> (openntpd openntpd-listen-on
>> openntpd-query-from openntpd-sensor openntpd-server
>> openntpd-servers openntpd-constraint-from
>> openntpd-constraints-from allow-large-adjustment?)
>> …))
>>
>> That’s all I was suggesting. The body of that procedure can remain
>> unchanged.
>>
>> Does that make sense?
>>
>
> Yes, that does make sense. Switching helped me find that I mistakenly
> used openntpd-<var> when it should've just been <var>, so I've fixed
> that. I've also added a default value field, like the ones that were
> recently added for the SQL services, and I tested that it worked with
> (service openntpd-service-type) in my test config.
Awesome.
> From 0c4d07cce671ad9131416f51098082286f241046 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <address@hidden>
> Date: Tue, 28 Nov 2017 10:19:11 +0200
> Subject: [PATCH] services: Add openntpd service.
>
> * gnu/packages/ntp.scm (openntpd)[arguments]: Add 'configure-flags to
> set openntpd daemon's user and localstatedir. Add a custom phase to not
> try to create said directory at install time.
> * gnu/services/networking.scm (<openntpd-configuration>): New record type.
> (openntpd-shepherd-service, openntpd-service-activation): New procedures.
> (openntpd-service-type): New variable.
> * doc/guix.texi (Networking Services): Add openntpd documentation.
[...]
> + (constraints-from openntpd-constriants-from
^^
Typo. :-)
Got for it!
Thank you,
Ludo’.