[bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags.

[Christopher Baines]

Leo Famulari <address@hidden> writes:

> On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote:
>> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New variable.
>
>> +         (add-after 'unpack 'rename-archive
>> +           (lambda _
>> +             (rename-file
>> +              ,(string-append "src/github.com/jessevdk/go-flags-" version)
>> +              "src/github.com/jessevdk/go-flags")
>> +             #t)))))
>
> I notice a few of these changes in your patch series. Can you give some
> detail about what's going on?
>
> If someone were developing with this library in the typical Go way,
> outside of Guix, would they have a problem here?
>
> Should the go-build-system try to handle this automatically?

I believe this might be connected with what is in the source
tarball. Without this stage, the go-flags directory is called
go-flags-1.3.0, and this causes the build to fail [2].

I'm not sure about the wider context, but it would be good to handle
this automatically.

1:
→ ls 
/tmp/guix-build-go-github.com-jessevdk-go-flags-1.3.0.drv-0/src/github.com/jessevdk/
go-flags-1.3.0

2:
starting phase `build'
can't load package: package github.com/jessevdk/go-flags: cannot find package 
"github.com/jessevdk/go-flags" in any of:
        
/gnu/store/9xvc0ml2dfgb58vlbc4sl6mv360jyh84-go-1.9.2/src/github.com/jessevdk/go-flags
 (from $GOROOT)
        
/tmp/guix-build-go-github.com-jessevdk-go-flags-1.3.0.drv-0/src/github.com/jessevdk/go-flags
 (from $GOPATH)
Building 'github.com/jessevdk/go-flags' failed.

signature.asc
Description: PGP signature