[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
From: |
Ludovic Courtès |
Subject: |
[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments. |
Date: |
Tue, 09 Jan 2018 09:52:17 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi Danny,
Danny Milosavljevic <address@hidden> skribis:
> On Mon, 08 Jan 2018 10:26:54 +0100
> address@hidden (Ludovic Courtès) wrote:
[...]
>> It’d feel more idiomatic to me if, instead, we had an
>> ‘operating-system-boot-kernel-arguments’ procedure that takes an OS and
>> returns (list --root --system …). Then it’d be up to the caller to
>> append that to what ‘operating-system-kernel-arguments’ returns.
>
> Yeah, but looking at it some more, it doesn't really need an OS. It needs
> the system derivation (and root device).
Since <operating-system> has a “gexp compiler”, you can write:
#~(string-append "--system=" #$os)
where ‘os’ is an <operating-system>. It automatically computes its
derivation. Thus, no need to explicitly call
‘operating-system-derivation’ and pass “system.drv” arguments around.
So we’d just need a slight adjustment to ‘bootable-kernel-arguments’ (so
that it takes the root device from the given OS object) and then rename
it to ‘operating-system-kernel-arguments’.
How does that sound?
Ludo’.
[bug#29932] [PATCH v2 1/2] system: Split up operating-system-kernel-arguments into operating-system-boot-kernel-arguments and operating-system-user-kernel-arguments., Danny Milosavljevic, 2018/01/12