[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29856] [PATCH core-updates] guix: python-build-system:, Modify ".py
[bug#29856] [PATCH core-updates] guix: python-build-system:, Modify ".py" files in-place.
Tue, 2 Jan 2018 18:26:27 +0100
thanks for the review!
On Tue, 2 Jan 2018 17:13:15 +0100
Hartmut Goebel <address@hidden> wrote:
> * it kills "from __future__ import", which must be the first import
> statement (or even the first statement after any doc-string) to work.
> Thus I suggest aiming to implement the solution discussed in that thread
> (see esp.
I like that approach. Nice...
> Beside of this, the patch suffers from some more issues. Sorry to say :-(
> * When converting PYTHONPATH into a list of python strings, these need
> to be quoted properly.
> * The description (commit-message) of the patch is much to terse. It
> should describe the the reason and implications. Esp. it should
> describe the case this is fixing.