[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>.
From: |
Arun Isaac |
Subject: |
[bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>. |
Date: |
Sun, 17 Dec 2017 04:42:42 +0530 |
Patch 1 modifies gnu-build-system to explicitly check the return value of each
phase for an unspecified value, and if found consider that phase to have
failed.
Patch 2 fixes several phases in gnu-build-system by making them return #t
instead of an unspecified value.
Patch 3 fixes the phases in several packages to return #t instead of an
unspecified value. I was testing patch 1, by trying to build bash. In doing
so, I found that the custom phases of many packages were not properly
returning #t, and fixed all those packages. No doubt, there are many more
packages that need fixing.
Arun Isaac (3):
build: gnu-build-system: Disallow phase returning <unspecified>.
build: gnu-build-system: Return #t from phases.
gnu: Return #t from phases.
gnu/packages/attr.scm | 3 ++-
gnu/packages/autotools.scm | 3 ++-
gnu/packages/base.scm | 3 ++-
gnu/packages/bash.scm | 3 ++-
gnu/packages/commencement.scm | 15 ++++++++++-----
gnu/packages/gcc.scm | 3 ++-
gnu/packages/libffi.scm | 3 ++-
gnu/packages/m4.scm | 3 ++-
gnu/packages/ncurses.scm | 6 ++++--
gnu/packages/perl.scm | 3 ++-
gnu/packages/readline.scm | 3 ++-
guix/build/gnu-build-system.scm | 18 +++++++++++++-----
12 files changed, 45 insertions(+), 21 deletions(-)
--
2.15.1
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>.,
Arun Isaac <=