[bug#29210] [PATCH] gnu: messaging: Add libsignal-protocol-c and enable OMEMO for dino.

[Ludovic Courtès]

Hi Rutger,

Rutger Helling <address@hidden> skribis:

> From 4212f0c4ffe43464ed7bd2e9f1a8f10e308ec792 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <address@hidden>
> Date: Wed, 8 Nov 2017 11:16:29 +0100
> Subject: [PATCH] gnu: messaging: Add libsignal-protocol-c.
>
> * gnu/packages/messaging.scm (libsignal-protocol-c): New variable.

[...]

> +  (arguments
> +   `(#:tests? #f
> +     ; Required for proper linking.
> +     #:configure-flags '("-DBUILD_SHARED_LIBS=on")))
> +     ; FIXME: With the below additional flags the tests pass, however this
> +     ; causes problems with timestamps, therefore the tests are disabled for
> +     ; now:
> +     ; -DCMAKE_BUILD_TYPE=Debug
> +     ; -DBUILD_TESTING=1

What are the timestamp issues you’re referring to above?  It would be
nice if we could have our cake and eat it too.  :-)

Besides, the default in ‘cmake-build-system’ is
“-DCMAKE_BUILD_TYPE=RelWithDebugInfo” (i.e., “-O2 -g”), and I think we
should keep it this way here.

Nipick: please use two semicolons for block comments like this (one
semicolon is for margin comments).

> +  (home-page "https://github.com/WhisperSystems/libsignal-protocol-c";)
> +  (synopsis "Ratcheting forward secrecy protocol")
> +  (description "libsignal-protocol-c is a ratcheting forward secrecy protocol
> +that works in synchronous and asynchronous messaging environments.")

Nitpicking here as well: it’s an /implementation/ of the protocol.
Could you also expound the description a little bit?

> +  (license license:gpl3)))

Since source file headers don’t say anything particular, it’s ‘gpl3+’
(“or any later version”.)

Could you send an updated patch?

> From db99f5874d24e0aa3e74005bf7200f459451aeb7 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <address@hidden>
> Date: Wed, 8 Nov 2017 11:18:38 +0100
> Subject: [PATCH] gnu: messaging: Enable OMEMO for dino.
>
> * gnu/packages/messaging.scm (dino) Update to commit 
> f6ac5bbd26638412a2289fd1d28ef12de1d7e8b5. [inputs]: Add libsignal-protocol-c, 
> libgcrypt. [arguments]: Change #configure-flags to 
> "-DSHARED_SIGNAL_PROTOCOL=yes".

OK!

Thank you,
Ludo’.