guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27554: Add dirvish and dependencies


From: Ricardo Wurmus
Subject: bug#27554: Add dirvish and dependencies
Date: Thu, 19 Oct 2017 01:16:24 +0200
User-agent: mu4e 0.9.18; emacs 25.3.1

Leo Famulari <address@hidden> writes:

> On Sun, Jul 02, 2017 at 05:20:37PM +0200, Ludovic Courtès wrote:
>> Hi Chris!
>>
>> Christopher Allan Webber <address@hidden> skribis:
>>
>> > From 60a448f1daf37927155577dabaf1c090f9404bee Mon Sep 17 00:00:00 2001
>> > From: Christopher Allan Webber <address@hidden>
>> > Date: Sat, 1 Jul 2017 20:45:04 -0500
>> > Subject: [PATCH 1/3] gnu: Add perl-libtime-parsedate.
>> >
>> > * gnu/packages/perl.scm (perl-libtime-parsedate): New variable.
>>
>> [...]
>>
>> > +    (arguments
>> > +     ;; Output when running tests:
>> > +     ;;   t/metdate.t ... skipped: It seems localtime() does not honor
>> > +     ;;   $ENV{TZ} when set in the test script.
>> > +     ;; Seemingly related:
>> > +     ;;   
>> > https://stackoverflow.com/questions/19956693/timeparsedate-install-fail
>> > +     ;;   https://rt.cpan.org/Public/Bug/Display.html?id=90367
>> > +     `(#:tests? #f))
>>
>> Perhaps if we add a dependency on tzdata and set TZDIR, as is done for
>> ‘duplicity’ for instance, the tests would run?
>>
>> Anyway this probably shouldn’t block the whole series!
>
> If it only uses them for tests, please use the special tzdata package
> that is just for tests, currently tzdata-2017a.

Thanks for the hint.

I’ve implemented the suggested changes and pushed these patches to
master with commit 0ff4425ce.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net






reply via email to

[Prev in Thread] Current Thread [Next in Thread]