guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer p


From: Thomas Danckaert
Subject: [bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin.
Date: Fri, 06 Oct 2017 16:02:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hartmut Goebel <address@hidden> writes:

> Add native-inputs pkg-config, qttools and update comments.
>
> This enables building the Qt Designer plugin.
>
> * gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
>   qttools.  [arguments]<#configure-flags>: Remove
>   PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT

I'm not sure what this does (or: used to do), so I don't know if this
removal needs a further comment.

> +     ;; TODO: Add bulding the super experimental QML support

There's a typo in your TODO ;-)

Just to comment on something, because otherwise all these patches LGTM (assuming
they still build, which I didn't verify).

Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]