guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28127] [PATCH 2/2] web: Add NGinx documentation.


From: Christopher Baines
Subject: [bug#28127] [PATCH 2/2] web: Add NGinx documentation.
Date: Thu, 5 Oct 2017 21:43:09 +0100

On Wed, 04 Oct 2017 16:48:13 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > * gnu/packages/web.scm (nginx): Add comment about deleting the
> > documentation. (nginx-xslscript): New variable.
> >   (nginx-docs): New variable.  
> 
> That’s a good idea!
> 
> > +(define-public nginx-docs
> > +  ;; This documentation should be relevant for nginx-1.12.0
> > +  (let ((revision 1961)
> > +        (changeset "dd4b6c564e10"))
> > +    (package
> > +      (name "nginx-docs")  
> 
> Maybe “nginx-doc” (singular)?

I wasn't sure about nginx-doc, so I have sent an updated patch using
nginx-documentation. 

> > +      (home-page "https://nginx.org";)
> > +      (synopsis "Documentation for NGinx")
> > +      (description
> > +       "The documentation for the NGinx web server.")  
> 
> “This package provides HTML documentation for the NGINX web
> server.” (?)
> 
> Also, s/NGinx/NGINX/ if I’m not mistaken.

I haven't seen any guidance on this, but the documentation itself uses
nginx (all lower case) as far as I can see, so I've switched to using
that.

I've sent an updated patch, thanks for your review :)

Attachment: pgpuwAA6oWnYh.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]