guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27853: [PATCH 2/2] services: Add memcached.


From: Christopher Baines
Subject: bug#27853: [PATCH 2/2] services: Add memcached.
Date: Sun, 30 Jul 2017 09:13:46 +0100

On Sat, 29 Jul 2017 22:23:39 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > * gnu/services/databases.scm (memcached-service-type,
> > %memcached-accounts): New variables.
> >   (<memcached-configuration>): New record type.
> >   (memcached-service-type): New procedures.
> > * gnu/tests/databases.scm: New file.
> > * doc/guix.texi (Database Services): Document the new memcached
> > service.
> > * gnu/local.mk (GNU_SYSTEM_MODULES): Add entry for
> > tests/memcached.scm.  
> 
> [...]
> 
> > address@hidden {Scheme Variable} memcached-service-type
> > +This is the service type for the @uref{https://memcached.org/,
> > Memcached} +service, which provides a distributed in memory cache.
> > The value for the service type is a @code{memcached-configuration}
> > object.  
> 
> Please wrap lines to 80 chars and leave two spaces after an
> end-of-sentence period.  :-)
> 
> > address@hidden @code{interfaces} (default: @code{'("0.0.0.0")})  
> 
> If that’s what upstream does, fine with me.
> 
> LGTM, thanks!

I've fixed the formatting in the docs, fixed one mistake in the commit
message and pushed. Thanks for your review :)

Attachment: pgpAUwXp4PIF9.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]