guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27421: [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase.


From: Kei Kebreau
Subject: bug#27421: [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase.
Date: Tue, 20 Jun 2017 19:51:19 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Marius Bakke <address@hidden> writes:

> Kei Kebreau <address@hidden> writes:
>
>> Marius Bakke <address@hidden> writes:
>>
>>> Kei Kebreau <address@hidden> writes:
>>>
>>>> * gnu/packages/games.scm (openttd-engine): Rename package to openttd.
>>>> [arguments]: Add it.
>>>> [native-inputs]: Add openttd-opengfx.
>>>
>>> This should also mention that the (openttd) variable is now gone.
>>> However, I would prefer keeping "openttd-engine" and only add these
>>> changes to the inherited "openttd" package. What do you think?
>>
>> That would be a more logical progression given the comment about adding
>> openttd-opengfx. I've attached the change you're talking about.
>
> LGTM, thanks!

All five patches pushed to master. Thanks for the review, Marius!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]