>From 44c356f50058a7d0c60523c1411150847ac66578 Mon Sep 17 00:00:00 2001 From: Alex Sassmannshausen Date: Mon, 10 Apr 2017 14:38:02 +0200 Subject: [PATCH] Use '@' as default separator in `package-full-name`. * guix/packages.scm (package-full-name): New optional argument, 'separator' defaulting to '@'. * gnu/packages/commencement.scm (gcc-boot0): Set use of '-' as `package-full-name` separator. * tests/graph.scm: Update tests to account for new `package-full-name`. * tests/profiles.scm: Update tests to account for new `package-full-name`. --- gnu/packages/commencement.scm | 2 +- guix/packages.scm | 7 ++++--- tests/graph.scm | 2 +- tests/profiles.scm | 7 ++++--- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 1b41feac1..552358d67 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -256,7 +256,7 @@ ;; Drop trailing letters, as gmp-6.0.0a unpacks ;; into gmp-6.0.0. `(symlink ,(string-trim-right - (package-full-name lib) + (package-full-name lib "-") char-set:letter) ,(package-name lib))) (list gmp-6.0 mpfr mpc)))) diff --git a/guix/packages.scm b/guix/packages.scm index 8ead95073..92b3f034c 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -385,9 +385,10 @@ object." package-cross-build-system-error?) -(define (package-full-name package) - "Return the full name of PACKAGE--i.e., `NAME-VERSION'." - (string-append (package-name package) "-" (package-version package))) +(define* (package-full-name package #:optional (separator "@")) + "Return the full name of PACKAGE, separated by SEPARATOR--i.e., address@hidden' by default." + (string-append (package-name package) separator (package-version package))) (define (%standard-patch-inputs) (let* ((canonical (module-ref (resolve-interface '(gnu packages base)) diff --git a/tests/graph.scm b/tests/graph.scm index 6431c482f..a48fbfd51 100644 --- a/tests/graph.scm +++ b/tests/graph.scm @@ -130,7 +130,7 @@ edges." (map (lambda (destination) (list "p-0.drv" (string-append - (package-full-name destination) + (package-full-name destination "-") ".drv"))) implicit))))))) diff --git a/tests/profiles.scm b/tests/profiles.scm index 093422792..ea2111355 100644 --- a/tests/profiles.scm +++ b/tests/profiles.scm @@ -239,12 +239,13 @@ ;; The inputs for grep and sed should be cross-build derivations, but that ;; for the glibc-utf8-locales should be a native build. (return (and (string=? (derivation-system drv) (%current-system)) - (string=? (find-input (package-full-name packages:grep)) + (string=? (find-input (package-full-name packages:grep "-")) (derivation-file-name grep)) - (string=? (find-input (package-full-name packages:sed)) + (string=? (find-input (package-full-name packages:sed "-")) (derivation-file-name sed)) (string=? (find-input - (package-full-name packages:glibc-utf8-locales)) + (package-full-name packages:glibc-utf8-locales + "-")) (derivation-file-name locales)))))) (test-assert "package->manifest-entry defaults to \"out\"" -- 2.12.2