[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27123: fonts: more changes to font-build-system, one follow up commi
From: |
ng0 |
Subject: |
bug#27123: fonts: more changes to font-build-system, one follow up commit |
Date: |
Mon, 29 May 2017 18:28:45 +0000 |
Arun Isaac transcribed 0.7K bytes:
>
> Thanks for the patches! Patches 1, 3 and 4 LGTM.
Ok.
> Patch 2...
>
> > * gnu/packages/fonts.scm (font-awesome)[source]: Switch to the source on
> > github as the previous zip file
> > is updated in place, resulting in a changed hash sum.
>
> This commit message line is too long. On emacs, you can wrap it to the
> next line with `fill-paragraph'.
Yeah, git commit message has no limit, otherwise I wrap at 70.
> The contents of the zip archive are updated in place without changing
> the version number? Is that what you mean by "in place"?
>
> Should we treat this as a one-time accident by upstream? Or have they
> made a habit out of this?
>
> IMO, we should forgive them this one time, and if they do this again,
> then we can move to their github release archive. WDYT?
>
It looks like this is done regulary, at least from their setup.
The 'assets' directory on the website where the zip file is
contained in comes from the tar.gz source.
I don't really think this patch should be applied, but we
should monitor the situation.
--
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588