[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.
From: |
Danny Milosavljevic |
Subject: |
bug#26815: [PATCH 2/3] vm: Support creating FAT partitions. |
Date: |
Sun, 7 May 2017 19:06:37 +0200 |
Hi Marius,
On Sun, 07 May 2017 17:52:43 +0200
Marius Bakke <address@hidden> wrote:
> I had that first, but the error handling was exactly identical, so opted
> to just handle it in the caller. It does sound safer to handle errors
> there instead of passing system* around though, will do that in lieu of
> other comments.
Yeah, I did that in the past, too (and for many things still do). But this
procedure is critical enough that ignoring the return value would do some very
strange things - and for those I lately do defensive programming.
> > "format-procedure" is not actually the procedure, right? It's already the
> > formatting-status ...
>
> Oops, an artifact of rebasing a lot of revisions...
Your v2 patch still calls it that :)
> > This adds nls_iso8859-1 unconditionally. OK.
>
> It's required by "dosfstools" which is also added unconditionally.
> Not sure how to improve it.
Oh, it's fine. It's just for other reviewers and future-me so that I don't
have to think about why this is done again...
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., (continued)
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., Marius Bakke, 2017/05/20
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., Ludovic Courtès, 2017/05/19
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., Ludovic Courtès, 2017/05/18
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., Marius Bakke, 2017/05/18
- bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images., Ludovic Courtès, 2017/05/19
- bug#26815: [PATCH v4 1/3] vm: Support arbitrary partition flags., Ludovic Courtès, 2017/05/17
bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Danny Milosavljevic, 2017/05/07
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Marius Bakke, 2017/05/07
- bug#26815: [PATCH v2 2/3] vm: Support creating FAT partitions., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.,
Danny Milosavljevic <=
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Marius Bakke, 2017/05/07
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Danny Milosavljevic, 2017/05/07
- bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Ludovic Courtès, 2017/05/08
bug#26815: [PATCH 2/3] vm: Support creating FAT partitions., Maxim Cournoyer, 2017/05/08
bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., Danny Milosavljevic, 2017/05/07
bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., Ludovic Courtès, 2017/05/08
bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., Maxim Cournoyer, 2017/05/08
bug#26815: [PATCH 1/3] vm: Add support for arbitrary partition flags., Danny Milosavljevic, 2017/05/08
bug#26815: [PATCH 0/3] Hybrid UEFI disk image, Marius Bakke, 2017/05/07