bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option.

[Mathieu Othacehe]

Hi Ludo,

Thanks for the review :)

>>    (display (_ "
>> +  -m, --manifest=FILE    select all the packages in FILE manifest"))
>
> “select all the package from the manifest in FILE” maybe?

Ok.

> Also, maybe s/get-manifest-packages/packages-from-manifest/, because
> ‘get-’ is quite unusual.  :-)

Seems better !

>
>> +         (packages
>> +          (or manifest-packages args-packages)))
>
> Maybe (append (match (assoc-ref opts 'manifest)
>                 (#f '())
>                 ((? string? file) (packages-from-manifest file)))
>               args-packages)

Mmh, I dont think we want to append manifest packages and args-packages.
We want only manifest packages if a manifest is specified IMO.

>
> ?
>
> Could you also update guix.texi to mention this option and the intended
> use case?

Sure.

I sent an updated patch taking your remarks into account.

Mathieu