[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26339: [PATCH 07/18] system: Add bootloader type.
From: |
Danny Milosavljevic |
Subject: |
bug#26339: [PATCH 07/18] system: Add bootloader type. |
Date: |
Sat, 15 Apr 2017 18:26:34 +0200 |
LGTM mostly. <Insert same comment about the same names as in the other patches>
> -(define* (grub-configuration #:optional (config (bootloader-configuration)))
> - (bootloader-configuration
> - (inherit config)
> - (bootloader (@ (gnu packages bootloaders) grub))
Hmm. Does that mean the user can't replace the bootloader package in the
configuration?
> -(define* (grub-efi-configuration #:optional (config
> (bootloader-configuration)))
> - (bootloader-configuration
> - (inherit (grub-configuration config))
> - (bootloader (@ (gnu packages bootloaders) grub-efi))))
Oh, so that's how. I think it would be nice-to-have if the user could also
override the bootloader package used.
> - (install-procedure install-syslinux)))
Wait, so install-syslinux wouldn't need to be exported from this module at all,
right?
Still nice that the user can use it - though is it worth exposing the
installers?
Otherwise LGTM!
bug#26339: [PATCH 12/18] system: Rename grub-device to fs->boot-device., Mathieu Othacehe, 2017/04/02
bug#26339: [PATCH 08/18] bootloader: Stop using grub module., Mathieu Othacehe, 2017/04/02
bug#26339: [PATCH 06/18] vm: Reword grub.cfg to boot.cfg, Mathieu Othacehe, 2017/04/02
bug#26339: [PATCH 10/18] system: Rename kernel->grub-label to kernel->boot-label., Mathieu Othacehe, 2017/04/02