guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26437: [PATCH] gnu: Add emacspeak.


From: Kei Kebreau
Subject: bug#26437: [PATCH] gnu: Add emacspeak.
Date: Tue, 11 Apr 2017 11:22:21 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Hello Kei,
>
> Kei Kebreau <address@hidden> skribis:
>
>> * gnu/packages/emacs.scm (emacspeak): New variable.
>
> [...]
>
>> +         (add-after 'install-espeak-server 'wrap-program
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (emacspeak (string-append out "/bin/emacspeak"))
>> +                    (espeak (string-append (assoc-ref inputs "espeak")
>> +                                          "/bin/espeak")))
>> +               (wrap-program emacspeak
>> +                 `("DTK_PROGRAM" ":" prefix (,espeak)))))))
>
> Please return #t here.  Could you also add a note about what
> ‘DTK_PROGRAM’ is and what component honors it?
>
>> +    (home-page "http://emacspeak.sourceforge.net";)
>> +    (synopsis "Audio desktop interface for Emacs")
>> +    (description
>> + "Emacspeak is an Emacs subsystem that provides complete speech
>> access.")
>
> Could you expound a bit, probably borrowing bits from their home page?
>
> Otherwise LGTM.  OK with these changes!
>
> Thanks,
> Ludo’.

Pushed to master with the required changes. Thanks for the review.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]