guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26239: [PATCH] packages: Use "@" as version separator.


From: Kei Kebreau
Subject: bug#26239: [PATCH] packages: Use "@" as version separator.
Date: Sat, 25 Mar 2017 19:42:52 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Tobias Geerinckx-Rice <address@hidden> writes:

> * guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
> PACKAGE-NAME and PACKAGE-VERSION.
> ---
>
> Guix,
>
> This is so trivial that I'm mainly posting it to find out *which* obvious
> thing I've completely missed. 
>
> Meanwhile, it won't get lost (again) before core-updates reopens for
> business.
>
> Kind regards,
>
> T G-R
>
> guix/packages.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index 4bc4b01..34bbc5e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -382,8 +382,8 @@ object."
>  
>  
>  (define (package-full-name package)
> -  "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  "Return the full name of PACKAGE--i.e., address@hidden'."
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

I think Guix internals could handle the change. As far as I can tell,
Bash and Guile have no problem with handling unquoted at signs in their
logic. I don't see hard-coded expectations of a hyphen rather than an at
sign in Guix's code either. Someone may want to double-check my
claims though.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]