guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26160: [PATCH] gnu: Add deutex.


From: Kei Kebreau
Subject: bug#26160: [PATCH] gnu: Add deutex.
Date: Sun, 19 Mar 2017 21:48:40 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Leo Famulari <address@hidden> writes:

> On Sat, Mar 18, 2017 at 04:24:48PM -0400, Kei Kebreau wrote:
>> gnu/packages/game-development.scm (deutex): New variable.
>
>> +        ;; "make install" is broken for this package.
>
> It's helpful to say how it's broken. That will make it easier to know
> if `make install` is fixed in future versions of DeuTex.
>

A copy of the updated explanation:

"make install" is broken for this package.
Notably, the binaries overrwrite one another upon installation as
they are all installed to the "bin" file in the output directory,
and the manual page fails to install because the directory for the
manual page is not created.

>> +        (replace 'install
>> +                 (lambda* (#:key outputs #:allow-other-keys)
>> +                   (let* ((out (assoc-ref %outputs "out"))
>> +                          (bin (string-append out "/bin"))
>> +                          (share (string-append out "/share")))
>> +                     (mkdir-p bin)
>
> This procedure is redundant; (install-file) will create the directory.
>

Redundant procedure removed.

> Otherwise, LGTM.

Pushed to master as 1a0c4437abbe3a1dd9622cc8a7926b9add74bf79. Thanks for
the review.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]