bug#25879: [PATCH] gnu: Add LLVM and CLANG 3.9.1.

[Catonano]

2017-02-26 12:01 GMT+01:00 Roel Janssen <address@hidden>:

Dear Guix,

Here's a patch to add LLVM and CLANG 3.9.1.  I need these to add
Darktable.  It could be that I messed up the commit message.  If I did,
please let me know the correct form.

Thanks!

Kind regards,
Roel Janssen

Ok, this has been sitting here or 6 days now, so even though I'm a beginner, I'll attempt an answer

I consulted the gnu standard, here

https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs

and based on that, I would say that the  lines

* gnu/packages/llvm.scm (llvm-3.9.1): New variable.

* gnu/packages/llvm.scm (clang-3.9.1): New variable.

* gnu/packages/llvm.scm (clang-runtime-3.9.1): New variable.

are ok

What leaves me dubious is the "and" in the subject line

The gnu standard doesn't mention anything about it but in the guix git repo log I can't see a single occurrence of an "and", probably because the habit is one patch per package

So I would suggest you to break this into a patchset of 2 parts: one with  llvm-3.9.1 with subject 

"[PATCH] gnu: Add LLVM"

* gnu/packages/llvm.scm (llvm-3.9.1): New variable.  

and another one with subect 

Subject: [PATCH] gnu: Add CLANG 3.9.1

* gnu/packages/llvm.scm (clang-3.9.1): New variable.

* gnu/packages/llvm.scm (clang-runtime-3.9.1): New variable.

the sencond one will have  clang-runtime-3.9.1 and clang-3.9.1 in it

That should do

As for if it builds and run, I'd leave that to someone else. My laptop overheats easily

HTH !