[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25733: [PATCH 08/18] gnu: Add python-routes.
From: |
ng0 |
Subject: |
bug#25733: [PATCH 08/18] gnu: Add python-routes. |
Date: |
Sat, 18 Feb 2017 15:36:38 +0000 |
On 17-02-18 13:15:18, Ricardo Wurmus wrote:
>
> address@hidden writes:
>
> > From: ng0 <address@hidden>
> >
> > * gnu/packages/python.scm (python-routes): New variable.
>
> […]
>
> > +(define-public python-routes
> > + (package
> > + (name "python-routes")
> > + (version "2.3.1")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (pypi-uri "Routes" version))
> > + (sha256
> > + (base32
> > + "0l83p5prsjq0cccm6596dpv1inlafa1p7q1v8rrvi40ivjsq1hwq"))))
> > + (build-system python-build-system)
> > + (inputs
>
> propagated-inputs.
>
> > + `(("python-repoze-lru" ,python-repoze-lru)
> > + ("python-six" ,python-six)
> > + ("python-coverage" ,python-coverage)
> > + ("python-webob" ,python-webob)
> > + ("python-webtest" ,python-webtest)
> > + ("python-nose" ,python-nose)))
> > + (home-page "http://routes.readthedocs.org/")
> > + (synopsis "Routing Recognition and Generation Tools")
>
> Please pay attention to upper vs lower case.
>
> > + (description
> > + "Routing package for Python that matches URLs to dicts and vice
> > versa.")
>
> Please use full sentences.
Most of the time those were simple packages where I would need to add
more than they do, but I can simply extend them so that the sentences
are correct, like "@code{foo} is a Foomatic package for Python which
does Foomagic in a foomatic way."
> > + (properties `((python2-variant . ,(delay python2-routes))))
>
> Please explain why this is needed.
Does any delayed variant do this? Back when I looked at them, none did
do this. More or less, build fails unless I add this for all packages
where it has been added.
> > + (license license:expat)))
> > +
> > +(define-public python2-routes
> > + (let ((base (package-with-python2
> > + (strip-python2-variant python-routes))))
> > + (package
> > + (inherit base))))
> > +
>
> The same comment applies here as for the other patches in this series.
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
> https://elephly.net
>
--
ng0 -- https://www.inventati.org/patternsinthechaos/
- bug#25733: [PATCH 14/18] gnu: Add python2-babel-1.3., (continued)
- bug#25733: [PATCH 14/18] gnu: Add python2-babel-1.3., contact . ng0, 2017/02/14
- bug#25733: [PATCH 06/18] gnu: Add python-dulwich-0.9.9., contact . ng0, 2017/02/14
- bug#25733: [PATCH 03/18] gnu: Add python-dulwich., contact . ng0, 2017/02/14
- bug#25733: [PATCH 05/18] gnu: Add python2-mysql-python., contact . ng0, 2017/02/14
- bug#25733: [PATCH 15/18] gnu: Add python-pyparsing-1.5.0., contact . ng0, 2017/02/14
- bug#25733: [PATCH 08/18] gnu: Add python-routes., contact . ng0, 2017/02/14
- bug#25733: [PATCH 12/18] gnu: Add python-docutils-0.11., contact . ng0, 2017/02/14
bug#25733: [PATCH 16/18] gnu: Add python-amqplib., contact . ng0, 2017/02/14
bug#25733: [PATCH 01/18] gnu: Add python-geventhttpclient., Ricardo Wurmus, 2017/02/18