Re: [PATCH 0/1] Go importer

[Pierre-Antoine Rouby]

Hi Leo,

----- Original Message -----
> From: "Leo Famulari" <address@hidden>

>> * guix/import/gopkg.scm: New file.
>> * guix/scripts/import/gopkg.scm: New file.
>> * guix/scripts/import.scm: Add 'gopkg'.
>> * Makefile.am: Add 'gopkg' importer in modules list.
> 
> I wonder which of the new files needs to be added to Makefile.am? My
> Autotools knowledge is not very strong...

Oups, yes guix/scripts/import/gopkg.scm need to added to Makefile.am, my bad.

> I noticed a couple issues with this code. First, the names of the
> temporary directories are predictable (they use an incrementing
> integer). Second, the temporary files are not deleted after the importer
> runs. I've attached a modified patch that addresses this by using ((guix
> utils) call-with-temporary-directory), which should address these
> problems. [0]

> What do you think of my patch? Does it still work for you?

I thinks the modifications doesn't works on my computer.

---------------------------------------------------------------------------
Backtrace:
          13 (apply-smob/1 #<catch-closure 9410a0>)
In ice-9/boot-9.scm:
    705:2 12 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8 11 (_ #(#(#<directory (guile-user) 9f8140>)))
In guix/ui.scm:
  1579:12 10 (run-guix-command _ . _)
In guix/scripts/import.scm:
   115:11  9 (guix-import . _)
In guix/scripts/import/gopkg.scm:
    85:19  8 (guix-import-gopkg . _)
In guix/utils.scm:
    633:8  7 (call-with-temporary-directory #<procedure f21e20 at ic…>)
In unknown file:
           6 (_ #<procedure f27f40 at ice-9/eval.scm:330:13 ()> #<p…> …)
           5 (_ #<procedure f27c40 at ice-9/eval.scm:330:13 ()> #<p…> …)
           4 (_ #<procedure f29800 at ice-9/eval.scm:330:13 ()> #<p…> …)
In ice-9/eval.scm:
   298:34  3 (_ #(#(#(#<directory (guix import gopkg) df78c0>) # …) …))
    619:8  2 (_ #(#(#<directory (guix import gopkg) df78c0> #<i…>) …))
In guix/serialization.scm:
   270:25  1 (write-file #<input: /tmp/guix-directory.H1Ut1e/Gopkg.…> …)
In unknown file:
           0 (lstat #<input: /tmp/guix-directory.H1Ut1e/Gopkg.toml 15>)

ERROR: In procedure lstat:
Wrong type (expecting string): #<input: /tmp/guix-directory.H1Ut1e/Gopkg.toml 
15>
---------------------------------------------------------------------------

--
Pierre-Antoine Rouby