[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: proposal: with-file-writeable
From: |
Ludovic Courtès |
Subject: |
Re: proposal: with-file-writeable |
Date: |
Fri, 16 Feb 2018 09:40:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marius Bakke <address@hidden> skribis:
> Gábor Boskovits <address@hidden> writes:
>
>> Ok, the keep it this way. Another question, this came up, as
>> I was trying to find a nice solution to reset-gzip-timestamps failing.
>> I got different pieces of advice if I should reset the permissions after
>> resetting the timestamp, but I'm still not sure. It seems that the easiest
>> way to this would be to just add a call to make-file-writable to the phase
>> at the beginning, as we finally end up with a read-only one in the store
>> anyway. I feel that reseting the permissions is unneccesary additional
>> complexity. WDYT?
>
> In the "strip" phase we already call "make-file-writeable"
> unconditionally, so doing it in reset-gzip-permissions as well should be
> okay I think.
Right, especially if this affects a number of packages already.
Ludo’.